----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51217/#review146709 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/os/windows/shell.hpp (lines 114 - 115) <https://reviews.apache.org/r/51217/#comment213276> Suggestion for the comment: ``` // On Windows, the `_spawnvp` call creates a new process. // In order to emulate the semantics of `execvp`, we spawn with `_P_WAIT`, // which force the parent process to block on the child. When the child exits, // the exit code is propagated back through the parent (via `exit()`). ``` Similar for the `execlp` comment, but s/vp/lp/. - Joseph Wu On Aug. 19, 2016, 10:38 a.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51217/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2016, 10:38 a.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, > Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Added `os::execlp' in `stout` library. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/shell.hpp > 1d73ae5fa7182ba433eaee0cc0034af6b36d77db > 3rdparty/stout/include/stout/os/windows/shell.hpp > c6e141aba0abe2c7fe5410e867f7db47d632e765 > > Diff: https://reviews.apache.org/r/51217/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Pravat > >
