> On Aug. 24, 2016, 10:04 p.m., Benjamin Mahler wrote: > > Ship It!
Note that the change isn't C++11 related (my TODO was suggesting to use a lambda which requires C++11, but your change just uses defer. Since this didn't use to work, I updated the commit summary to be the following: ``` commit 0fb5faf667afebf236e6f6b264ffd15bdcff2726 Author: Gastón Kleiman <[email protected]> Date: Wed Aug 24 15:04:54 2016 -0700 Removed a no longer needed function disambiguation. It appears that with the compiler versions we now support, this disambiguation is no longer necessary. Review: https://reviews.apache.org/r/50853/ ``` - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50853/#review146720 ----------------------------------------------------------- On Aug. 5, 2016, 3:30 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50853/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2016, 3:30 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Resolved C++11-related TODO in master/master.cpp. > > > Diffs > ----- > > src/master/master.cpp 92595097c8f26675aee122c8a11366262534db64 > > Diff: https://reviews.apache.org/r/50853/diff/ > > > Testing > ------- > > `make check` in OS X, Centos 7, Centos 6, Debian 8, Fedora 23, Ubuntu 14, > Ubuntu 12, Ubuntu 15, Ubuntu 16 > > > Thanks, > > Gastón Kleiman > >
