----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51400/#review146757 -----------------------------------------------------------
Ship it! Ship It! - Gilbert Song On Aug. 24, 2016, 10:22 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51400/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2016, 10:22 p.m.) > > > Review request for mesos, Gilbert Song and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > The extra message is introduced in: > https://reviews.apache.org/r/28141. > > I don't see a strong reason why we need such messages from that patch. > Furthermore, the message is not quite useful because it is not the > root cause of the destroy. Finally, the `Executor terminated` message > no longer applies when we destroy a nested container. The same message > is already generated properly in the agent. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 1f414cfa332d9a3f8b8f04343249e02924e39d89 > src/slave/containerizer/mesos/containerizer.cpp > 8a8985a6627859365c4f87ea0cbb5f89190cd4b3 > src/tests/containerizer/mesos_containerizer_tests.cpp > c0dda11c18a770f594b9dcf2e506ec624706dbbd > > Diff: https://reviews.apache.org/r/51400/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
