> On Aug. 19, 2016, 1:36 a.m., Jie Yu wrote: > > src/linux/capabilities.cpp, lines 297-313 > > <https://reviews.apache.org/r/51042/diff/1/?file=1472102#file1472102line297> > > > > Should this just be a `set`? > > > > Also, we should just assume we have SETPCAP as agent is typically > > running as root.
We want to be able to call this e.g., after changing the UID which always clears the effective set, so I left this code in. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51042/#review146148 ----------------------------------------------------------- On Aug. 25, 2016, 5:18 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51042/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2016, 5:18 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-5051 > https://issues.apache.org/jira/browse/MESOS-5051 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/capabilities.hpp fd7a571a62e3bbdd8a0453f800bf622457891bf8 > src/linux/capabilities.cpp e58cb981f9cf7880524114e94ba42cbacfe45630 > > Diff: https://reviews.apache.org/r/51042/diff/ > > > Testing > ------- > > make check and sudo make check (Debian jessie, gcc-4.9.2, w/o optimizations) > > > Thanks, > > Benjamin Bannier > >
