----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51432/#review146815 -----------------------------------------------------------
Fix it, then Ship it! src/tests/master_validation_tests.cpp (line 1665) <https://reviews.apache.org/r/51432/#comment213518> s/executors/an executor/ i'll fix this while committing. - Vinod Kone On Aug. 25, 2016, 5:25 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51432/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2016, 5:25 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6087 > https://issues.apache.org/jira/browse/MESOS-6087 > > > Repository: mesos > > > Description > ------- > > Added test case for TaskGroupValidationTest.ExecutorWithoutFrameworkId. > > > Diffs > ----- > > src/tests/master_validation_tests.cpp > 86b4b22350175af592876fd2f6d3fecca7acabce > > Diff: https://reviews.apache.org/r/51432/diff/ > > > Testing > ------- > > make > make check > > ``` > ./bin/mesos-tests.sh > --gtest_filter="TaskGroupValidationTest.ExecutorWithoutFrameworkId" > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from TaskGroupValidationTest > [ RUN ] TaskGroupValidationTest.ExecutorWithoutFrameworkId > [ OK ] TaskGroupValidationTest.ExecutorWithoutFrameworkId (92 ms) > [----------] 1 test from TaskGroupValidationTest (92 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (105 ms total) > [ PASSED ] 1 test. > ``` > > > Thanks, > > Guangya Liu > >
