----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/#review146824 -----------------------------------------------------------
src/slave/containerizer/docker.cpp (lines 230 - 249) <https://reviews.apache.org/r/50599/#comment213537> I would probably move this into the next patch alongside the other changes to the flags and not even bother with the comment. - Kevin Klues On Aug. 22, 2016, 10:12 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50599/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2016, 10:12 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Added a new string entry 'devices' to 'docker::Flags' to > indicate host devices exposed into docker container, and > passed allocated GPUs to it. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp f2a06065cf99fed934c2c1ffc47461ec8a97f50d > src/slave/containerizer/docker.cpp 5c1ee8e467d1c54c60b67dc5275ef71e1bb90723 > > Diff: https://reviews.apache.org/r/50599/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >