-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51433/#review146850
-----------------------------------------------------------


Fix it, then Ship it!




I'll fix the issues while committing.


src/tests/master_authorization_tests.cpp (line 235)
<https://reviews.apache.org/r/51433/#comment213604>

    // This test verifies that if one of the tasks in a task group is 
unauthorized, all the tasks in
    // the task group are rejected.



src/tests/master_authorization_tests.cpp (line 292)
<https://reviews.apache.org/r/51433/#comment213605>

    // Create an authorized task.


- Vinod Kone


On Aug. 25, 2016, 6:19 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51433/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2016, 6:19 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6087
>     https://issues.apache.org/jira/browse/MESOS-6087
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test case MasterAuthorizationTest, UnauthorizedTaskGroup.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_authorization_tests.cpp 
> 92bd2a9463f861e4b479f76927dd01324765a411 
> 
> Diff: https://reviews.apache.org/r/51433/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> ```
> ./bin/mesos-tests.sh  
> --gtest_filter="MasterAuthorizationTest.UnauthorizedTaskGroup"
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from MasterAuthorizationTest
> [ RUN      ] MasterAuthorizationTest.UnauthorizedTaskGroup
> [       OK ] MasterAuthorizationTest.UnauthorizedTaskGroup (85 ms)
> [----------] 1 test from MasterAuthorizationTest (86 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (105 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to