> On Aug. 26, 2016, 2:15 p.m., Benjamin Bannier wrote: > > src/tests/containerizer/capabilities_tests.cpp, lines 139-145 > > <https://reviews.apache.org/r/51450/diff/2/?file=1486620#file1486620line139> > > > > I had some difficulty undestanding the issue with this `NOTE`. > > > > How about something like > > > > ~~~~ > > Some RedHat-based distributions install `ping` with `NET_RAW` and > > `NET_ADMIN` in both the effective and permitted set in the file > > capabilities. We only require `NET_RAW` for our tests, while `NET_RAW` is > > needed for setting packet marks > > (https://bugzilla.redhat.com/show_bug.cgi?id=802197). Since these > > capabilities are in the file effective set, the kernel will lift them to > > the effective set, regardless of whether they are needed or not. This issue > > seems to be fixed in later versions > > (https://bugzilla.redhat.com/show_bug.cgi?id=1142311). > > ~~~~
Of course I meant to write > while `NET_ADMIN` is needed for setting packet marks ... - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51450/#review146942 ----------------------------------------------------------- On Aug. 26, 2016, 8 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51450/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, 8 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > Fixed a capabilities test failure on Fedora 23. > > > Diffs > ----- > > src/tests/containerizer/capabilities_tests.cpp > ec75698cb969d745c82a8358e54e8d8b24f14f7c > > Diff: https://reviews.apache.org/r/51450/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
