----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51451/#review147006 -----------------------------------------------------------
Fix it, then Ship it! i'll fix it before committing. src/tests/master_authorization_tests.cpp (lines 503 - 510) <https://reviews.apache.org/r/51451/#comment213954> lets just set the expectation on dispatch first and set both promises. ``` Future<Nothing> recoverResources = FUTURE_DISPATCH(_, &MesosAllocatorProcess::recoverResources); promise1.set(true); proise2.set(true); ``` - Vinod Kone On Aug. 26, 2016, 8:08 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51451/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, 8:08 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6087 > https://issues.apache.org/jira/browse/MESOS-6087 > > > Repository: mesos > > > Description > ------- > > Added test case MasterAuthorizationTest.KillPendingTaskInTaskGroup. > > > Diffs > ----- > > src/tests/master_authorization_tests.cpp > d0fe4bed24077d68cc31a3ea031bb9b04a14165d > > Diff: https://reviews.apache.org/r/51451/diff/ > > > Testing > ------- > > make > make check > > ``` > ./bin/mesos-tests.sh > --gtest_filter="MasterAuthorizationTest.KillPendingTaskInTaskGroup" > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from MasterAuthorizationTest > [ RUN ] MasterAuthorizationTest.KillPendingTaskInTaskGroup > [ OK ] MasterAuthorizationTest.KillPendingTaskInTaskGroup (88 ms) > [----------] 1 test from MasterAuthorizationTest (89 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (100 ms total) > [ PASSED ] 1 test. > ``` > > > Thanks, > > Guangya Liu > >
