-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51412/#review147160
-----------------------------------------------------------


Ship it!




Will commit with the minor edit.


src/master/master.hpp (line 853)
<https://reviews.apache.org/r/51412/#comment214270>

    This method also "updates the slave's resources by applying the given 
operation."


- Jiang Yan Xu


On Aug. 29, 2016, 12:20 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51412/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2016, 12:20 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4431
>     https://issues.apache.org/jira/browse/MESOS-4431
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is being added to allow for handling of ACCEPT call within the
> allocator in the future. For now, we expose the offered resources
> in this API to account for additional copies of shared resources in
> the allocator when there are more tasks being launched in a single
> ACCEPT call for a single copy of shared resource being offered.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp 
> 41a9d457286e30431490ca626e680d85684b48d6 
>   src/master/allocator/mesos/allocator.hpp 
> 69639be9c14b83157df29f767e819db719588053 
>   src/master/allocator/mesos/hierarchical.hpp 
> bdbc6d3b5b959990538f4e3b7b1a3b031d9aea05 
>   src/master/allocator/mesos/hierarchical.cpp 
> 234ef98529964a0b6d3f132426a6c8ccbb1263ee 
>   src/master/master.hpp b118293823d37bba9b751aac12e0403318ce5736 
>   src/master/master.cpp 2b4aff80385d02c71dc3eeff4ddda326c9824ede 
>   src/tests/allocator.hpp 5ca3057265eb2c00c965132ac7922019e1cc77b8 
>   src/tests/hierarchical_allocator_tests.cpp 
> ddd48694e5c2d3d01fbff20558a46c1256b3dbc3 
>   src/tests/reservation_tests.cpp 6181c6f8abbf254b45ea77f33c48dee918106ef0 
> 
> Diff: https://reviews.apache.org/r/51412/diff/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Reply via email to