----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51358/#review147368 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/paths.cpp (line 122) <https://reviews.apache.org/r/51358/#comment214482> Shouldn't you check if the entries are directories here? src/slave/containerizer/mesos/provisioner/paths.cpp (lines 131 - 138) <https://reviews.apache.org/r/51358/#comment214483> You should change the return type to a `Result`. - Joseph Wu On Aug. 29, 2016, 2:20 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51358/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2016, 2:20 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph > Wu, and Kevin Klues. > > > Bugs: MESOS-6067 > https://issues.apache.org/jira/browse/MESOS-6067 > > > Repository: mesos > > > Description > ------- > > Implemented recursive helper method findContainerDir for provisioner. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/paths.hpp > 9829d6b52c8547ae22297a5bc47852ce5a219e4c > src/slave/containerizer/mesos/provisioner/paths.cpp > 86a45f30c22dc1e41f4779c0ce8c11d02dcc46bb > > Diff: https://reviews.apache.org/r/51358/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
