----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51392/#review147380 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/paths.cpp (lines 151 - 153) <https://reviews.apache.org/r/51392/#comment214508> You should comment that the lambda is present because we don't want the `parentContainerId` to be in the public function. src/slave/containerizer/mesos/provisioner/paths.cpp (lines 193 - 195) <https://reviews.apache.org/r/51392/#comment214506> You don't really need to check if the subcontainers are empty here. - Joseph Wu On Aug. 29, 2016, 2:20 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51392/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2016, 2:20 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph > Wu, and Kevin Klues. > > > Bugs: MESOS-6067 > https://issues.apache.org/jira/browse/MESOS-6067 > > > Repository: mesos > > > Description > ------- > > This patch supports collecting all containerIds (all containers in the > nested hierarchy) recursively. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/paths.cpp > 86a45f30c22dc1e41f4779c0ce8c11d02dcc46bb > > Diff: https://reviews.apache.org/r/51392/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
