----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51565/#review147511 -----------------------------------------------------------
Patch looks great! Reviews applied: [51565] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Aug. 31, 2016, 10:23 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51565/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2016, 10:23 p.m.) > > > Review request for mesos, Benjamin Mahler, Cody Maloney, Artem Harutyunyan, > and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > The provided `LogrotateContainerLogger` did not have enough granularity > when setting log rotation settings. This patch adds a way for each > executor to set its own log rotation settings, using the global values > as defaults. > > The executor settings are provided via environment variables in the > `ExecutorInfo`. > > > Diffs > ----- > > docs/logging.md 3b36870c22336440b0d7bf1359e1d0a97986a0f6 > src/slave/container_loggers/lib_logrotate.hpp > f216548ef37f5c2245ef64d21e84e06100e8e5ae > src/slave/container_loggers/lib_logrotate.cpp > 01552752a56ee7377a631a783f2168ba0eea2799 > src/tests/container_logger_tests.cpp > e8f934106510fe02b8b92be19c918a1e5c0b78fd > > Diff: https://reviews.apache.org/r/51565/diff/ > > > Testing > ------- > > Previewed documentation change via the website previewer. > > make check > > > Thanks, > > Joseph Wu > >
