----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51553/#review147651 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (lines 686 - 689) <https://reviews.apache.org/r/51553/#comment214870> Since here you are applying the `operations` one by one, I think that it is better to update the log message here by adding the `operation` in the output here so that people will know which `operation` updated the resources each time. - Guangya Liu On 九月 1, 2016, 4:35 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51553/ > ----------------------------------------------------------- > > (Updated 九月 1, 2016, 4:35 p.m.) > > > Review request for mesos and Anindya Sinha. > > > Repository: mesos > > > Description > ------- > > This is needed for supporting LAUNCH operations with shared resources > (More details in https://reviews.apache.org/r/45961/) but this patch > itself has no functional change. > > Also, this patch together with https://reviews.apache.org/r/51412/ > results in no change in the granularity in which Offer operations are > applied. Each single operation in the ACCEPT call is still individually > applied to Resources objects managed by the master, the allocator and > the sorters, same as before. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 9e5db2196c6a541dc1208ba8b9f13ef9a518bcc4 > > Diff: https://reviews.apache.org/r/51553/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jiang Yan Xu > >
