----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51359/#review147657 -----------------------------------------------------------
src/tests/containerizer/provisioner_paths_tests.cpp (lines 56 - 61) <https://reviews.apache.org/r/51359/#comment214877> How about ``` ASSERT_SOME(os::mkdir(containerDir1)); ASSERT_SOME(os::mkdir(containerDir2)); ASSERT_SOME(os::mkdir(containerDir3)); ``` src/tests/containerizer/provisioner_paths_tests.cpp (lines 63 - 65) <https://reviews.apache.org/r/51359/#comment214878> How about ``` EXPECT_SOME_EQ( containerDir1, findContainerDir(provisionerDir, child1).get()); ``` and ditto for others - Guangya Liu On 八月 29, 2016, 9:20 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51359/ > ----------------------------------------------------------- > > (Updated 八月 29, 2016, 9:20 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph > Wu, and Kevin Klues. > > > Bugs: MESOS-6067 > https://issues.apache.org/jira/browse/MESOS-6067 > > > Repository: mesos > > > Description > ------- > > Added unit test for provisioner helper findContainerDir. > > > Diffs > ----- > > src/Makefile.am 8dc4175c60e4a9776ddb8ad21774fa4b30c28d00 > src/tests/containerizer/provisioner_paths_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/51359/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
