----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50693/ -----------------------------------------------------------
(Updated 九月 3, 2016, 4:29 a.m.) Review request for mesos, Benjamin Mahler, Vinod Kone, and Jiang Yan Xu. Summary (updated) ----------------- Added a `createSlaveInfo()` overload that takes a `Resources`. Repository: mesos Description (updated) ------- Also changed the benchmarks to use it because it's unnecessary to recreate the same Resources objects for each agent. Diffs ----- src/tests/hierarchical_allocator_tests.cpp d960b7575ed5531753e9329e5774b6909090edf8 Diff: https://reviews.apache.org/r/50693/diff/ Testing ------- make make check Before fix adding 30000 agents. ``` [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.Metrics/32 Set quota for 1 roles in 1216us Added 1 frameworks in 509us Added 30000 agents in 14.515326secs /metrics/snapshot took 48615us for 30000 agents and 1 frameworks [ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.Metrics/32 (14679 ms) [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (14679 ms total) ``` After fix adding 30000 agents. ``` [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.Metrics/32 Set quota for 1 roles in 1238us Added 1 frameworks in 555us Added 30000 agents in 13.976131secs /metrics/snapshot took 58360us for 30000 agents and 1 frameworks [ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.Metrics/32 (14139 ms) [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (14140 ms total) ``` Thanks, Guangya Liu
