> On Sept. 6, 2016, 2:36 p.m., Vinod Kone wrote: > > src/tests/slave_tests.cpp, line 2907 > > <https://reviews.apache.org/r/50707/diff/2/?file=1485830#file1485830line2907> > > > > I think pausing the rate limiter here is a bit confusing because you > > are essentially stopping `SlaveObserver::markUnreachable` from being > > processed. > > > > Instead I would suggest to not use a mock limiter, but just drop the > > `Master::_markUnreachable` dispatch before you induced unregistration. You > > would still need to spoof the dispatch but I think that is closer to the > > race.
That approach sounds fine to me, although if we're going to use that method, it seems like there is no point in having the slave fail health checks in the first place: we can just have the slave disconnect via `UnregisterSlaveMessage`, then spoof the dispatch to `Master::markUnreachable` to simulate a race with the `SlaveObserver`. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50707/#review147836 ----------------------------------------------------------- On Sept. 6, 2016, 3:27 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50707/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 3:27 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4049 > https://issues.apache.org/jira/browse/MESOS-4049 > > > Repository: mesos > > > Description > ------- > > This test tries to simulate a race between marking an agent unhealthy > and receiving an `UnregisterSlaveMessage` for that agent. > > Unfortunately, this test is a little fragile (we need to manually > dispatch an event to the master process to simulate the action that > would be taken by the slave observer). > > > Diffs > ----- > > src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 > > Diff: https://reviews.apache.org/r/50707/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
