> On Sept. 7, 2016, 5:29 p.m., Vinod Kone wrote: > > > > Anand Mazumdar wrote: > I intentionally omitted putting the backticks since I was just renaming > function calls/moving code around due to the refactoring. We might consider > doing a sweep later. What do you think?
I think we are just doing this for whatever lines we touch. I'll leave it upto you. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51478/#review148031 ----------------------------------------------------------- On Sept. 7, 2016, 10:11 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51478/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2016, 10:11 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6076 > https://issues.apache.org/jira/browse/MESOS-6076 > > > Repository: mesos > > > Description > ------- > > This change modified the agent mocks/tests to account for the > `runTask()`/`_runTask()` refactoring. > > Review: https://reviews.apache.org/r/51478/ > > > Diffs > ----- > > src/tests/master_slave_reconciliation_tests.cpp > 7dda6f67d9d02d14759563ec64269060dc7e643b > src/tests/mesos.hpp 4cae54b4df906d4b7e8fe8d40d5b0ad59d260e6f > src/tests/mesos.cpp f5034f9f8de7040182e10f51be125a87b29fdd24 > src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 > > Diff: https://reviews.apache.org/r/51478/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
