----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51720/#review148247 -----------------------------------------------------------
Patch looks great! Reviews applied: [51272, 51273, 51274, 51275, 51276, 51277, 51278, 51442, 51405, 51720] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 8, 2016, 2:24 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51720/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2016, 2:24 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Bugs: MESOS-6141 > https://issues.apache.org/jira/browse/MESOS-6141 > > > Repository: mesos > > > Description > ------- > > In some of our tests we manually create a 'PosixLauncher' rather than > relying on the value of 'flags.launcher' to decide which type of > launcher to create. Since calls to 'CreateSlaveFlags()' set > 'flags.launcher' to 'linux' by default, there was a discrepency in > what the flags said, and what actual launcher type we were creating. > > This commit fixes this to explicitly set 'flags.launcher' to the > appropriate type. > > > Diffs > ----- > > src/tests/container_logger_tests.cpp > e8f934106510fe02b8b92be19c918a1e5c0b78fd > src/tests/containerizer/isolator_tests.cpp > f8056ca08029feed5f164d4f94e24d521183bdfc > src/tests/containerizer/mesos_containerizer_tests.cpp > 72346c748598e4c0787dba09d9ccb59f244b0df5 > > Diff: https://reviews.apache.org/r/51720/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kevin Klues > >
