> On Sept. 6, 2016, 6:35 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp, line 417 > > <https://reviews.apache.org/r/50270/diff/6/?file=1491898#file1491898line417> > > > > Why this is not guarded by ifdef linux? > > Benjamin Bannier wrote: > I was trying to minimize code behind `ifdef` guards. While it should not > be possible to set the capabilities flag on non-Linux systems the `Flag` > member is defined for all platforms as it has no dependencies on > Linux-specific features.
this won't compile on non linux machines, right? Since `flags.capabilities` is only defined on Linux build. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50270/#review147872 ----------------------------------------------------------- On Sept. 7, 2016, 4:43 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50270/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2016, 4:43 p.m.) > > > Review request for mesos, Jay Guo and Jie Yu. > > > Bugs: MESOS-5303 > https://issues.apache.org/jira/browse/MESOS-5303 > > > Repository: mesos > > > Description > ------- > > This change introduces linux capability based security for unified > containerizer. A new agent flag \`allowed_capabilities\` has been > introduced to override the default capabilities of the user or the > capabilities requested by the user. > > This feature is only available on linux. > > > Diffs > ----- > > src/slave/containerizer/mesos/launch.hpp > 0e86da9c7bd9c7fbedd7102d66b902d1c10e5e0b > src/slave/containerizer/mesos/launch.cpp > 13b65d82e029650e150eb2bc3647d95af167bd72 > src/slave/flags.hpp 1a006663e7cc58ee548b3dda686cfbac0c240baa > src/slave/flags.cpp 0f2be1700f41b74da4ea1ce699a81ec33cf92a9a > > Diff: https://reviews.apache.org/r/50270/diff/ > > > Testing > ------- > > `make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o > optimizations) > > > Thanks, > > Benjamin Bannier > >
