----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51511/#review148472 -----------------------------------------------------------
3rdparty/libprocess/src/encoder.hpp (line 259) <https://reviews.apache.org/r/51511/#comment215924> Do we want to fast fail on all errors returned by `close` or just `EBADFD`? This can fail on `EINTR` or `EIO` right? - Joris Van Remoortere On Aug. 30, 2016, 1 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51511/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 1 a.m.) > > > Review request for mesos, Benjamin Mahler, Artem Harutyunyan, and Joris Van > Remoortere. > > > Bugs: MESOS-6104 > https://issues.apache.org/jira/browse/MESOS-6104 > > > Repository: mesos > > > Description > ------- > > This check will force libprocess to fail fast if a file descriptor > is closed underneath it. > > > Diffs > ----- > > 3rdparty/libprocess/src/encoder.hpp > 9cd0d3f55f2e9c9dc9ebb97b34a23375f8d4e07f > > Diff: https://reviews.apache.org/r/51511/diff/ > > > Testing > ------- > > Re-ran the steps in the previous review for several minutes. Saw that the > master did not CHECK fail. > > > Thanks, > > Joseph Wu > >