----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51805/#review148581 -----------------------------------------------------------
Patch looks great! Reviews applied: [50235, 50416, 50417, 50418, 50422, 50699, 50700, 50701, 50702, 50703, 50704, 50705, 50706, 50707, 50844, 50845, 50846, 51020, 51371, 51374, 51375, 51376, 51377, 51021, 51706, 51653, 51707, 51805] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 12, 2016, 4:02 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51805/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 4:02 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4049 > https://issues.apache.org/jira/browse/MESOS-4049 > > > Repository: mesos > > > Description > ------- > > When a task launched by a partition-aware framework is running on an > agent that becomes partitioned from the master, the framework will now > receive TASK_UNREACHABLE, not TASK_LOST. > > Similarly, when a partition-aware framework does explicit reconciliation > for an agent ID that appears in the "unreachable" list in the registry, > the master will now return TASK_UNREACHABLE rather than TASK_LOST. > > > Diffs > ----- > > src/master/master.cpp 1dcce6cd66804990af238176c61aca03bb5c9471 > src/tests/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00 > src/tests/reconciliation_tests.cpp 8e438bfbce508a074f0d54513cd752344238e3f2 > > Diff: https://reviews.apache.org/r/51805/diff/ > > > Testing > ------- > > make check on OSX and Linux. > > > Thanks, > > Neil Conway > >
