> On 九月 10, 2016, 4 a.m., Guangya Liu wrote: > > src/tests/master_validation_tests.cpp, line 1722 > > <https://reviews.apache.org/r/51771/diff/1/?file=1495218#file1495218line1722> > > > > s/ContainerInfo Type/`ContainerInfo` > > s/DOCKER/`DOCKER` > > Vinod Kone wrote: > don't think we use backticks for enum names?
Yes, thanks Vinod. @Abhishek, please ignore the second one above for `DOCKER`. > On 九月 10, 2016, 4 a.m., Guangya Liu wrote: > > src/tests/master_validation_tests.cpp, line 1928 > > <https://reviews.apache.org/r/51771/diff/1/?file=1495218#file1495218line1928> > > > > s/ContainerInfo Type/`ContainerInfo` > > s/DOCKER/`DOCKER` Please ignore the second one for `DOCKER`. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51771/#review148397 ----------------------------------------------------------- On 九月 9, 2016, 8:21 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51771/ > ----------------------------------------------------------- > > (Updated 九月 9, 2016, 8:21 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6144 > https://issues.apache.org/jira/browse/MESOS-6144 > > > Repository: mesos > > > Description > ------- > > DOCKER as ContainerInfo Type for both task group executor as well as > taskgroup task is currently not supported. Only MESOS as > ContainerInfo Type is supported. This patch is to validate that > TaskGroup executor and tasks do not use DOCKER ContainerInfo. > > > Diffs > ----- > > src/master/validation.cpp 137b9f912029d6b0287b49541d1af9bb1fdb80b3 > src/tests/master_validation_tests.cpp > 3a5cfa2b8a500c1c9e8af5207ebb91279a61feed > > Diff: https://reviews.apache.org/r/51771/diff/ > > > Testing > ------- > > On Ubuntu 16.04: > sudo make -j`nproc` check > > > Thanks, > > Abhishek Dasgupta > >
