----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51377/#review148613 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On Aug. 24, 2016, 3:51 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51377/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2016, 3:51 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4049 > https://issues.apache.org/jira/browse/MESOS-4049 > > > Repository: mesos > > > Description > ------- > > When a slave is being removed but before the registry operation to > remove it has completed, querying the HTTP endpoints at the master > should not indicate that the slave has been removed yet. This is > important because the registry update might fail; if the master > fails over, the new master will not have removed the slave. > > > Diffs > ----- > > src/tests/master_tests.cpp 398164d09b8ef14f916122ed8780023c4a3cd0f6 > > Diff: https://reviews.apache.org/r/51377/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
