----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51840/#review148707 -----------------------------------------------------------
Patch looks great! Reviews applied: [51840] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 13, 2016, 9:26 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51840/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2016, 9:26 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-6153 > https://issues.apache.org/jira/browse/MESOS-6153 > > > Repository: mesos > > > Description > ------- > > The data structures hold the tasks here uses as raw ptrs which makes > it hard for users to leverage RAII to avoid leaks. Instead we here now > create a temporary value, and if needed insert a copy into the task > list. > > > Diffs > ----- > > src/slave/slave.cpp 2c7b5ada1aa81babb9ceee0c9f928685878a778c > > Diff: https://reviews.apache.org/r/51840/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Bannier > >
