----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51850/#review148793 -----------------------------------------------------------
Patch looks great! Reviews applied: [51850] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 13, 2016, 5:04 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51850/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2016, 5:04 p.m.) > > > Review request for mesos, Anindya Sinha and Guangya Liu. > > > Repository: mesos > > > Description > ------- > > We can remove these given that they already call > `Resources::add/remove(const Resource_&)` internally and > a Resource is implicitly convertible to a Resource_. > > > Diffs > ----- > > include/mesos/resources.hpp 87828aa5e4818efd40dd72dc199669281b8a15ae > include/mesos/v1/resources.hpp 27bdd275277edc60d97b720e596f21e8e8f8dc27 > src/common/resources.cpp 77ee92193de1f34131f7a86b7d16731c9c3e17e2 > src/v1/resources.cpp 4ba5bf87c9b9fef67eeb447a3f3b520f1e81ad77 > > Diff: https://reviews.apache.org/r/51850/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
