----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51856/#review148881 -----------------------------------------------------------
Fix it, then Ship it! Ship It! src/slave/slave.hpp (line 1022) <https://reviews.apache.org/r/51856/#comment216393> s/string/std::string - Guangya Liu On 九月 13, 2016, 9:20 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51856/ > ----------------------------------------------------------- > > (Updated 九月 13, 2016, 9:20 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6151 > https://issues.apache.org/jira/browse/MESOS-6151 > > > Repository: mesos > > > Description > ------- > > This change adds the relevant logic to ensure that agent correctly > populates the command info for default executors. Since, we > don't yet have the executable `mesos-default-execute`, added > a `TODO` to the test to add a check to ensure the command > has that information. > > > Diffs > ----- > > src/slave/constants.hpp 0ad59adc1d44014acd756b87d572e835c6325b5f > src/slave/slave.hpp e659c44fcc415f10a6980e7b29cc1ce536dfe657 > src/slave/slave.cpp 2c7b5ada1aa81babb9ceee0c9f928685878a778c > src/tests/slave_tests.cpp 2f3fa5fae634b6250f3c00bbef3077493f79af95 > > Diff: https://reviews.apache.org/r/51856/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
