----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51902/#review149011 -----------------------------------------------------------
Fix it, then Ship it! LGTM! Just a bit of language tweaking... (ditto for the v1 protos). include/mesos/mesos.proto (lines 1873 - 1874) <https://reviews.apache.org/r/51902/#comment216551> How about `Base` or `Type` or `Root`? I feel `Container` is over-used in this protobuf :) include/mesos/mesos.proto (line 1881) <https://reviews.apache.org/r/51902/#comment216552> I'm guessing upwards traversal (i.e. `../../somewhere`) is not allowed. Should we note that here? - Joseph Wu On Sept. 14, 2016, 6:35 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51902/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2016, 6:35 p.m.) > > > Review request for mesos, Gilbert Song, Joseph Wu, and Vinod Kone. > > > Bugs: MESOS-6160 > https://issues.apache.org/jira/browse/MESOS-6160 > > > Repository: mesos > > > Description > ------- > > This new volume source allows sibling containers to share an ephemeral > volume from their parent container's sandbox. In the future, it'll > also allow sibling containers to share persistent volume, external > volume or host volume from their parent. > > > Diffs > ----- > > include/mesos/mesos.proto eb61b6243202464da2307d06d80700f19f9c25d4 > include/mesos/v1/mesos.proto 62231522f4bfddfc6c440a299dd01080cbe25f6a > > Diff: https://reviews.apache.org/r/51902/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
