> On Sept. 14, 2016, 8:31 p.m., Vinod Kone wrote: > > src/tests/cluster.hpp, line 137 > > <https://reviews.apache.org/r/51375/diff/2-3/?file=1496850#file1496850line137> > > > > Can you add a NOTE here regarding why you declared it here? You can use > > most of the text from your review comment.
Per discussion, existing comment seems sufficient. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51375/#review148960 ----------------------------------------------------------- On Sept. 15, 2016, 7:36 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51375/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2016, 7:36 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4049 > https://issues.apache.org/jira/browse/MESOS-4049 > > > Repository: mesos > > > Description > ------- > > This allows test cases to inspect how the master interacts with > the registry. > > This commit changes `tests::cluster::Master` to use `MockRegistrar` > exclusively, even for test cases that aren't interested in mocking > aspects of the master <-> registrar interaction. However, this should be > harmless, since by default `MockRegistrar` behaves identically to the > normal registrar. > > > Diffs > ----- > > src/Makefile.am f1d202ae08d6bb4fd9e11eb1eae75dd9d5d9d8d5 > src/master/registrar.hpp c39dd1b5430084e51376143b5441db346e85a153 > src/tests/cluster.hpp c6fbbf24e04c38cc9a94ce0c13db445c03e804c7 > src/tests/cluster.cpp b04653af97d17aaa9d0d3ee872169b66cd67126b > src/tests/mock_registrar.hpp PRE-CREATION > src/tests/mock_registrar.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/51375/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
