> On 九月 14, 2016, 6 p.m., Jiang Yan Xu wrote: > > I didn't add additional comments because the conversion is intentionally > > implicit. I guess we can clarify further by saying "Note that `Resource` > > objects are implicitly converted to `Resource_`" here but this is true > > elsewhere in resources.cpp as well.
Yes, but I think that it is still deserved to update the comments as most of the APIs are still accepting the `Resource` object but not `Resource_` object, so it is better to mention `that Resource objects are implicitly converted to Resource_` in comments. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51877/#review148940 ----------------------------------------------------------- On 九月 14, 2016, 2:03 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51877/ > ----------------------------------------------------------- > > (Updated 九月 14, 2016, 2:03 a.m.) > > > Review request for mesos, Benjamin Mahler and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > The API for += and -= `Resource` object are now removed, we should > update the comments for += and -= `Resource_` object by telling > end user for how to convert a `Resource` object to a `Resource_` > object when += and -= a `Resource` object. > > > Diffs > ----- > > include/mesos/resources.hpp 7ba422d57d47777e058c682df9aa780557782423 > include/mesos/v1/resources.hpp add48c7baf8fabf5cc443d60a6c96d2902fc67de > > Diff: https://reviews.apache.org/r/51877/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
