> On Sept. 15, 2016, 12:22 p.m., Avinash sridharan wrote: > > src/common/type_utils.cpp, line 417 > > <https://reviews.apache.org/r/51825/diff/1/?file=1497315#file1497315line417> > > > > Can we use "." instead of "/" as the delimiter. Reason being that in > > `network/cni` isolator we plan to use the stringified version of > > `ContainerID` to create directories for containers. This would result in > > creating a hierarchy. Using "." instead of "/" would prevent it from > > creating hierarchies. Also, recreating `ContainerID` from a flat hierarchy > > structure, would much more cleaner.
We will have the recreate mothod later. :) - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51825/#review149116 ----------------------------------------------------------- On Sept. 15, 2016, 12:46 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51825/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2016, 12:46 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph > Wu, Kevin Klues, and Vinod Kone. > > > Bugs: MESOS-6073 > https://issues.apache.org/jira/browse/MESOS-6073 > > > Repository: mesos > > > Description > ------- > > Updated the streaming function for ContainerID to be nesting aware. > > > Diffs > ----- > > src/common/type_utils.cpp c7d50334b4e56bc0eb5473b9f9277465b607334f > src/tests/containerizer/mesos_containerizer_tests.cpp > 96e24500a12825161553eb050da389088b122695 > > Diff: https://reviews.apache.org/r/51825/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
