----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51919/#review149128 -----------------------------------------------------------
Fix it, then Ship it! src/tests/hierarchical_allocator_tests.cpp (lines 1388 - 1389) <https://reviews.apache.org/r/51919/#comment216668> s/in offer to/only offered to/ s/only// (Basically move `only` up for more emphasis) src/tests/hierarchical_allocator_tests.cpp (line 1390) <https://reviews.apache.org/r/51919/#comment216669> Mention `Capability` in the test name helps clarify what the test focuses on. Maybe `SharedResourcesCapability`? src/tests/hierarchical_allocator_tests.cpp (lines 1411 - 1415) <https://reviews.apache.org/r/51919/#comment216649> We haven't done so consistently but in new tests let's use abstractions more often to make tests shorter. ``` Resources volume = createDiskResource(5, "role1", "id1", None(), None(), true); ``` Perhaps we should update `UpdateAllocationSharedPersistentVolume` as well. src/tests/hierarchical_allocator_tests.cpp (lines 1417 - 1419) <https://reviews.apache.org/r/51919/#comment216652> ``` CREATE(volume); ``` src/tests/hierarchical_allocator_tests.cpp (line 1462) <https://reviews.apache.org/r/51919/#comment216670> `createFrameworkInfo` takes a `capabilities` argument. - Jiang Yan Xu On Sept. 15, 2016, 9:46 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51919/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2016, 9:46 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-4325 > https://issues.apache.org/jira/browse/MESOS-4325 > > > Repository: mesos > > > Description > ------- > > Added test to validate capability of SHARED_RESOURCES. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 7705de95a3916310baf4daca62aab1e6b1ca3cb3 > > Diff: https://reviews.apache.org/r/51919/diff/ > > > Testing > ------- > > Tests passed (including the test added in this RR). > > > Thanks, > > Anindya Sinha > >
