> On Sept. 14, 2016, 4:56 p.m., Anindya Sinha wrote:
> > src/slave/slave.hpp, line 671
> > <https://reviews.apache.org/r/51867/diff/1/?file=1498235#file1498235line671>
> >
> >     nitpik: totalResources is the same as `info.resources()` with 
> > checkpointed resources applied (and nothing else). So, how about:
> >     
> >     s/includes/is the same as

To say it's "the same" we have to emphasize "quantity" but for brevity I just 
did

s/It includes/i.e.,/


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51867/#review149000
-----------------------------------------------------------


On Sept. 14, 2016, 11:21 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51867/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2016, 11:21 a.m.)
> 
> 
> Review request for mesos, Anindya Sinha and Neil Conway.
> 
> 
> Bugs: MESOS-4668
>     https://issues.apache.org/jira/browse/MESOS-4668
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `totalResources` is updated by CheckpointResourcesMessages and doesn't
> have to be re-calculated in Slave::usage(). This change allows us to
> expose `totalResources` for other purposes as well.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp e659c44fcc415f10a6980e7b29cc1ce536dfe657 
>   src/slave/slave.cpp 2c7b5ada1aa81babb9ceee0c9f928685878a778c 
> 
> Diff: https://reviews.apache.org/r/51867/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Reply via email to