> On Sept. 14, 2016, 5:10 p.m., Anindya Sinha wrote:
> > src/slave/http.cpp, line 986
> > <https://reviews.apache.org/r/51869/diff/1/?file=1498238#file1498238line986>
> >
> >     Add this new field `reserved_resources` in `string 
> > Slave::Http::STATE_HELP()`.

Should we punt on this until MESOS-3568 is addressed?


> On Sept. 14, 2016, 5:10 p.m., Anindya Sinha wrote:
> > src/slave/http.cpp, line 987
> > <https://reviews.apache.org/r/51869/diff/1/?file=1498238#file1498238line987>
> >
> >     Add this new field `unreserved_resources` in `string 
> > Slave::Http::STATE_HELP()`.

Should we punt on this until MESOS-3568 is addressed?


> On Sept. 14, 2016, 5:10 p.m., Anindya Sinha wrote:
> > src/slave/http.cpp, line 985
> > <https://reviews.apache.org/r/51869/diff/1/?file=1498238#file1498238line985>
> >
> >     Maybe good to add a comment and/or document regarding what the field 
> > `resources` contains... since it changed from `info.resources()` to 
> > `info.resources() + checkointed resources applied`.

The comment on the `slave->totalResources` is clear so I'd expect it should be 
obvious to the reader of the code (to at least look it up, for this field and 
other fields that get written to the output in this method).

As to the change from `info.resources()` to `totalResources` yeah it's worth 
documenting in the CHANGLOG (which I'll do) but I guess more importantly we 
should probably add the reservation information to the (more formally defined) 
operator API where they should be documented. I'll look into that as well.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51869/#review149001
-----------------------------------------------------------


On Sept. 14, 2016, 11:21 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51869/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2016, 11:21 a.m.)
> 
> 
> Review request for mesos, Anindya Sinha and Neil Conway.
> 
> 
> Bugs: MESOS-6085
>     https://issues.apache.org/jira/browse/MESOS-6085
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also the 'resource' field now exposes the total resources, which is
> consistent with the same field in the master's /slaves endpoint.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 67463105d7fa38b2158a64f6994e3dd353a9fcc7 
> 
> Diff: https://reviews.apache.org/r/51869/diff/
> 
> 
> Testing
> -------
> 
> make check. A new test is added in https://reviews.apache.org/r/51870/.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Reply via email to