----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51955/#review149234 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On Sept. 16, 2016, 12:59 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51955/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2016, 12:59 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5951 > https://issues.apache.org/jira/browse/MESOS-5951 > > > Repository: mesos > > > Description > ------- > > When the master fails over, agents have `agent_reregister_timeout` to > reregister with the new master. Any agents that fail to reregister > within the timeout will be marked unreachable in the registry. > Previously, frameworks would only receive a `slaveLost` callback for > such agents if the master was running in "registry_strict" mode. This > commit changes the master to always inform frameworks about lost agents, > regardless of the "registry_strict" flag. > > > Diffs > ----- > > src/master/master.cpp b88472f6350d3f71e057bab34822423da5427151 > src/tests/master_tests.cpp 6cde15fcd6ca8ec40438c75aed980e83f8de9b86 > > Diff: https://reviews.apache.org/r/51955/diff/ > > > Testing > ------- > > `make check` on OSX and Linux. > > > Thanks, > > Neil Conway > >
