-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51871/#review149243
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 26)
<https://reviews.apache.org/r/51871/#comment216814>

    Don't need this anymore.



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 836 - 842)
<https://reviews.apache.org/r/51871/#comment216812>

    I'd prefer subprocess here.  `os::shell` has un-suppressable/capturable 
output.
    
    And although it seems impossible for the CNI isolator... spaces in the 
filename will mess up the copy.



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 1486)
<https://reviews.apache.org/r/51871/#comment216803>

    Oops :)


- Joseph Wu


On Sept. 16, 2016, 9:49 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51871/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2016, 9:49 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6156
>     https://issues.apache.org/jira/browse/MESOS-6156
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The network file setup in the `network/cni` isolator is now nesting
> aware. Since the children share the network and UTS namespace with the
> parent, the network files need to be created only for the parent
> container. For the child containers, the network files will be simply
> a symlink to a parents network files.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 822f11eab5b00c014563322a8c3b2c14cb440e0b 
> 
> Diff: https://reviews.apache.org/r/51871/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> sudo ./bin/mesos-tests.sh
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to