> On Sept. 16, 2016, 10:04 p.m., Joseph Wu wrote:
> > src/slave/containerizer/mesos/isolators/namespaces/pid.cpp, lines 87-89
> > <https://reviews.apache.org/r/51963/diff/1/?file=1500272#file1500272line87>
> >
> >     Do we care to check for the entire token?  AFAIK, imported symbol names 
> > don't necessarily restrict the `/` character.  So if someone creates a 
> > `not-filesystem/linux` isolator, this check will pass.

I agree that the check is a bit hacky, but we do checks like this all over the 
place for lack of something better.  Ideally, `flags.isolation` would get 
parsed out to a `set` of strings that we could then do a look up on instead of 
just searching the string.

As such, I think this check is OK for now (its at least consisten with how 
things are done in the rest of the code base), but we should do a blanket 
update at some point to add a parser to `flags.isolation` that parses the input 
into a `set`.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51963/#review149283
-----------------------------------------------------------


On Sept. 16, 2016, 7:20 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51963/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2016, 7:20 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Gilbert Song, Joseph Wu, and 
> Kevin Klues.
> 
> 
> Bugs: MESOS-6145
>     https://issues.apache.org/jira/browse/MESOS-6145
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The bind mounts in the pid namespace isolator turns out to be
> unnecessary as the linux launcher will use freezer to kill all tasks
> anyway. It makes the isolator unnecessarily complex, and has a mount
> leak bug (MESOS-6145). This patch removes all the unnecessary bind
> mounts, making the isolator extremely simple.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/namespaces/pid.hpp 
> 1c74ba2561c113c4611577c541b2baed13717ece 
>   src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 
> b41e2665e4c9089da55b38aa5d0bedbc1a60e6a8 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> d0f92856780f087908731ec0601692c78339d8a7 
>   src/tests/containerizer/isolator_tests.cpp 
> 9bb1e69209f34b18b5b64c3daf5ea26780f2ab74 
>   src/tests/slave_recovery_tests.cpp 389daf0f5af9a2786619312253f78cd9160b080b 
> 
> Diff: https://reviews.apache.org/r/51963/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to