-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51988/
-----------------------------------------------------------

(Updated Sept. 17, 2016, 7:47 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

Updated the comment


Bugs: MESOS-6186
    https://issues.apache.org/jira/browse/MESOS-6186


Repository: mesos


Description
-------

In a previous iteration of attempting to make this isolator nested
aware, we (incorrectly) decided to return a 'Failure()' in 'watch()'
for nested containers. However, we shouldn't just blindly fail this
call for nested containers. Instead we should just return a 'Future'
that will never be satisfied. This way it is safe to call 'watch()'
for nested containers, without any unwanted side effects.

This commit fixes this issue.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
ed7150a9b53c577fc248f8af2be55c6b12f64303 

Diff: https://reviews.apache.org/r/51988/diff/


Testing
-------

$ GTEST_FILTER="" make -j check
$ sudo src/mesos-tests


Thanks,

Kevin Klues

Reply via email to