----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51989/#review149342 -----------------------------------------------------------
Ship it! Ship It! - Kevin Klues On Sept. 17, 2016, 7:33 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51989/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2016, 7:33 p.m.) > > > Review request for mesos, Benjamin Hindman, Gilbert Song, and Kevin Klues. > > > Bugs: MESOS-6194 > https://issues.apache.org/jira/browse/MESOS-6194 > > > Repository: mesos > > > Description > ------- > > The disk space check will be done at the top container level. All > nested container will not have separate disk space check for now. > > In theory, this change is not necessary for now as we can simply mark > the isolator as nesting unaware. However, in the future, we might want > to do separate disk check for each nested container and report > limitations for them. Therefore, we include this patch as a starting > point. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/posix/disk.hpp > 3998251248ecef2d174f0ea68e0493d09b012952 > src/slave/containerizer/mesos/isolators/posix/disk.cpp > 5b9d5aaeb008e9b102e86736c9312db0b3266d34 > > Diff: https://reviews.apache.org/r/51989/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
