----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51870/#review149369 -----------------------------------------------------------
src/tests/reservation_endpoints_tests.cpp (lines 1652 - 1654) <https://reviews.apache.org/r/51870/#comment216947> I think you `settle` here to wait for `Slave::checkpointResources` finished, would it better to add a comment to descirbe why need to settle here? - haosdent huang On Sept. 14, 2016, 6:21 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51870/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2016, 6:21 p.m.) > > > Review request for mesos, Anindya Sinha and Neil Conway. > > > Bugs: MESOS-6085 > https://issues.apache.org/jira/browse/MESOS-6085 > > > Repository: mesos > > > Description > ------- > > Added a test for reservation info from the agent's endpoint. > > > Diffs > ----- > > src/tests/reservation_endpoints_tests.cpp > bee5ea6b3a3ee7fafb7312a6d89de79d62c57ec1 > > Diff: https://reviews.apache.org/r/51870/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
