-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52004/#review149382
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines 138 - 142)
<https://reviews.apache.org/r/52004/#comment216976>

    This needs to be updated.



src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 164)
<https://reviews.apache.org/r/52004/#comment216977>

    What other cases? Can you be more specific here.



src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines 230 - 232)
<https://reviews.apache.org/r/52004/#comment216978>

    The comment here needs to be updated as well. Please do a sweep to fix all 
the comments in this file.


- Jie Yu


On Sept. 18, 2016, 5:30 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52004/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2016, 5:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
> Wu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6190
>     https://issues.apache.org/jira/browse/MESOS-6190
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported docker runtime isolator to be nested aware.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.hpp 
> ac0397f65bb2a675ad1eae0f7cfa95f10145fc63 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> b589cd691ae6aacd2dcd00878e43d58f15abfe11 
> 
> Diff: https://reviews.apache.org/r/52004/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to