----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52007/#review149389 -----------------------------------------------------------
Discussed offline. Looks like the sandbox related method should not be in slave/paths.hpp|cpp. Task/Executor related path functions should be in there, but sandbox related should be moved to src/slave/containerizer/mesos/paths.hpp|cpp - Jie Yu On Sept. 18, 2016, 5:31 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52007/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2016, 5:31 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph > Wu, Kevin Klues, and Vinod Kone. > > > Bugs: MESOS-6191 > https://issues.apache.org/jira/browse/MESOS-6191 > > > Repository: mesos > > > Description > ------- > > Updated 'parseExecutorRunPath()' for nested sandbox support. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > ea418252956c8089acc5a491888ed7f6df6cafcd > src/slave/paths.hpp ebff3a9fab3f4a8d38502fe02bd5a34cf95c1830 > src/slave/paths.cpp eb414caae5847949854743d4e3c603217a897898 > src/tests/paths_tests.cpp 0671ee25b484cacf08c9a20ee6eba88e6f14fa97 > > Diff: https://reviews.apache.org/r/52007/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
