-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52018/#review149415
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/launcher.cpp (line 133)
<https://reviews.apache.org/r/52018/#comment217032>

    The indent here seems not correct, should be 4 spaces.


- Qian Zhang


On Sept. 19, 2016, 3:50 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52018/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2016, 3:50 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed Hook to ParentHook in Mesos.
> 
> 
> Diffs
> -----
> 
>   src/linux/systemd.cpp 619aa2778da5f99d3a078a8e1208bdaa9dc77581 
>   src/slave/container_loggers/lib_logrotate.cpp 
> 1c170e5d11ef31d468b200c2c4cbd27abeeb418a 
>   src/slave/containerizer/docker.cpp a47e2ed88dcadb211c7f8c92eb4bada348d42780 
>   src/slave/containerizer/mesos/launcher.hpp 
> 61c2e84a3cebc308a8a65e536fa07fa1cf8f5838 
>   src/slave/containerizer/mesos/launcher.cpp 
> 73a0e5f50042b1249224a4a42e2442b7ea51dfff 
>   src/slave/containerizer/mesos/linux_launcher.hpp 
> dca827cba4d1ead90dba036c9b94ba5e3a3f82fe 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 1c49f568b12f5ad688bb43625de3dcbfd618ca79 
>   src/tests/containerizer/launcher.hpp 
> f87b3ce92c6a5d996995833d79c976db6afe2700 
> 
> Diff: https://reviews.apache.org/r/52018/diff/
> 
> 
> Testing
> -------
> 
> sudo make check + internal ci
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to