-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51999/#review149431
-----------------------------------------------------------




include/mesos/resources.hpp (line 184)
<https://reviews.apache.org/r/51999/#comment217049>

    s/Resource/`Resource` objects
    
    ditto for v1



include/mesos/resources.hpp (line 186)
<https://reviews.apache.org/r/51999/#comment217048>

    s/Resource/`Resource` objects
    
    ditto for v1



include/mesos/resources.hpp (line 197)
<https://reviews.apache.org/r/51999/#comment217050>

    s/Resources/vector of `Resource` objects
    
    ditto for v1



include/mesos/resources.hpp (line 200)
<https://reviews.apache.org/r/51999/#comment217056>

    A unit test is needed for this.



src/common/resources.cpp (line 435)
<https://reviews.apache.org/r/51999/#comment217051>

    s/Resource protobufs/`Resource` objects



src/common/resources.cpp (line 437)
<https://reviews.apache.org/r/51999/#comment217052>

    s/Resources object/vector of `Resource` objects



src/common/resources.cpp (line 441)
<https://reviews.apache.org/r/51999/#comment217054>

    kill `and empty Resource objects will return an error.`



src/common/resources.cpp (line 447)
<https://reviews.apache.org/r/51999/#comment217053>

    s/Resource protobufs/`Resource` objects



src/common/resources.cpp (line 580)
<https://reviews.apache.org/r/51999/#comment217055>

    s/Try<vector<Resource>> result/const Try<vector<Resource>> result



src/slave/containerizer/containerizer.cpp (lines 64 - 71)
<https://reviews.apache.org/r/51999/#comment217059>

    A question here: Does the `resources` here will include the zero value 
resource?
    
    If so, what is the differencen of this code block and `Resources::parse()`? 
The `Resources::parse()` seems similar as here.


- Guangya Liu


On 九月 19, 2016, 5:01 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51999/
> -----------------------------------------------------------
> 
> (Updated 九月 19, 2016, 5:01 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6062
>     https://issues.apache.org/jira/browse/MESOS-6062
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> During parsing of resources in the startup flags of mesos agent, all
> the valid resources (including empty resources) are accumulated in a
> vector of Resource protobufs.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 3ef8cacee529addc745b4aeb6398d7606c61b749 
>   include/mesos/v1/resources.hpp ef56b4960b103a3efd916fab64796aa334ba44c6 
>   src/common/resources.cpp 4602bff22ec7ff77f069056085ad92bfa04595f3 
>   src/slave/containerizer/containerizer.cpp 
> d46882baa904fd439bffb23c324828b777228f1c 
>   src/tests/resources_tests.cpp 3e493007d6d1d8194d07035aaa1cde28dedf2b5a 
>   src/v1/resources.cpp 7c4db44d4c31a8295cc16b0ce1ef5adf314e6ac6 
> 
> Diff: https://reviews.apache.org/r/51999/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Reply via email to