----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52039/#review149538 -----------------------------------------------------------
Patch looks great! Reviews applied: [50235, 50416, 50417, 50418, 50422, 50699, 50700, 50701, 50702, 50703, 50704, 50705, 50706, 50707, 50844, 50845, 50846, 51020, 51371, 51374, 51375, 51376, 51377, 51021, 51706, 51653, 51707, 51805, 51845, 51891, 51909, 51913, 51953, 51954, 51955, 51956, 51957, 51958, 52039] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 19, 2016, 2:54 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52039/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2016, 2:54 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > We want to cause the agent to shutdown gracefully (i.e., to send an > "unregister" message to the master). This can be accomplished by sending > the whole process a SIGUSR1 but that seems fragile; using the agent's > `shutdown()` method seems more robust. > > > Diffs > ----- > > src/tests/slave_tests.cpp 696e0f71190238133f29b6380bc58b994a556e69 > > Diff: https://reviews.apache.org/r/52039/diff/ > > > Testing > ------- > > `make check` on OSX. > > > Thanks, > > Neil Conway > >
