----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52108/#review149785 -----------------------------------------------------------
src/launcher/default_executor.cpp (line 230) <https://reviews.apache.org/r/52108/#comment217493> You may want `endl` to the end. ``` cout << "Received kill for task '" << taskId << "'" << endl; ``` Fixed here https://reviews.apache.org/r/52109/diff/1#index_header src/tests/default_executor_tests.cpp (line 151) <https://reviews.apache.org/r/52108/#comment217496> I was a bit confused: For which case we need to add quota for enum values and which cannot? The update in `src/launcher/default_executor.cpp` including quota for enum values but here for `TASK_KILLED` does not use quota. - Guangya Liu On 九月 21, 2016, 1:14 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52108/ > ----------------------------------------------------------- > > (Updated 九月 21, 2016, 1:14 a.m.) > > > Review request for mesos, Anand Mazumdar and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Just like LAUNCH_GROPU implementation this is a dummy implementation > that sends the TASK_KILLED upates without doing any actual kills. > > > Diffs > ----- > > src/launcher/default_executor.cpp f0feb95f7f07710bd0cea6f2ac87ef5b875f31ec > src/tests/default_executor_tests.cpp > 055a3d76e0224265f51b8393406070c6032541fc > > Diff: https://reviews.apache.org/r/52108/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
