> On Sept. 20, 2016, 9:30 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp, > > lines 110-115 > > <https://reviews.apache.org/r/52090/diff/1/?file=1505879#file1505879line110> > > > > you can use os::pagesize() here
Orz, thank you very much! Didn't realize we have this util function before. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52090/#review149733 ----------------------------------------------------------- On Sept. 20, 2016, 7:20 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52090/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2016, 7:20 p.m.) > > > Review request for mesos, Zhiwei Chen, Gilbert Song, Jie Yu, and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Fixed compile error in ppc64le. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp > a1c87ce2ace33f1a779e843578f55d7502562c8d > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp > bab10ae5d488585603db2637ae15ee02b1982354 > > Diff: https://reviews.apache.org/r/52090/diff/ > > > Testing > ------- > > Fix the error saw in > https://builds.apache.org/job/Mesos-PPC64LE/154/BUILDTOOL=autotools,COMPILER=gcc,CONFIGURATION=--verbose,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,label_exp=ppc64le/console > > > Thanks, > > haosdent huang > >
