----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52129/#review149885 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Sept. 21, 2016, 7:20 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52129/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2016, 7:20 p.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, and Jie Yu. > > > Repository: mesos > > > Description > ------- > > This changes the `ChildHook::SETSID` to a noop on Windows > as there is no equivalent functionality on this OS. > > By default, the lifetime of child processes on Windows are not > tied to the parent process (`setsid()` on Posix prevents child > processes from dying when the parent dies). > > > Diffs > ----- > > 3rdparty/libprocess/src/subprocess.cpp > 6f50a714285cd7bc05d57c476e400a1fa5246796 > > Diff: https://reviews.apache.org/r/52129/diff/ > > > Testing > ------- > > make check (OSX) > > In progress: msbuild.exe ... (Windows) > > > Thanks, > > Joseph Wu > >
