> On Sept. 20, 2016, 11:30 p.m., Vinod Kone wrote:
> > Updated summary and description to say "nested" instead of "child" 
> > containers.

Ah, good catch thanks.


> On Sept. 20, 2016, 11:30 p.m., Vinod Kone wrote:
> > include/mesos/v1/agent/agent.proto, line 103
> > <https://reviews.apache.org/r/52057/diff/2/?file=1505957#file1505957line103>
> >
> >     The first part of this sentence should be moved to "ContainerID" proto?

Hm.. this is the only place that a user has to set the ContainerID and so I 
figured it would be prudent to document it here so that they know how to 
generate one. I did a re-write where I mention that the user is responsible for 
generating one (and it needs to be a UUID) so hopefully that looks better, let 
me know.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52057/#review149755
-----------------------------------------------------------


On Sept. 20, 2016, 7:34 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52057/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2016, 7:34 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2449
>     https://issues.apache.org/jira/browse/MESOS-2449
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows the executor to manage child containers within its
> container. This is useful for the implementation of task groups
> ("pod"-like containers) as well as for executors that would like
> to implement isolation between sub-tasks.
> 
> This initial patch provides the ability to launch, wait, and
> destroy child containers. This was added as an agent API rather
> than an executor API in order to enable operators to inject
> subcontainers for future use-cases. For example, an operator
> may want to inject a debugging container at run-time.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 5b91677487f8e23301e67af14c2115c6b4a533ac 
>   include/mesos/v1/agent/agent.proto 8145669073553dc8aa56cfe2c0a0b756d70fee0e 
>   src/slave/http.cpp 2cbf3c57e294f0d47d64915371b4a6bbf9cdfc0a 
>   src/slave/slave.hpp e659c44fcc415f10a6980e7b29cc1ce536dfe657 
>   src/slave/validation.cpp a9f318214182a87783a985cd8495a0ec00c95378 
> 
> Diff: https://reviews.apache.org/r/52057/diff/
> 
> 
> Testing
> -------
> 
> Tests will be added alongside the implementation.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Reply via email to