----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52154/ -----------------------------------------------------------
Review request for mesos, Joris Van Remoortere and Till Toenshoff. Bugs: MESOS-6216 https://issues.apache.org/jira/browse/MESOS-6216 Repository: mesos Description ------- This code modified the process environment in order to support upgrading on the fly from old-style libprocess SSL variables `SSL_` to `LIBPROCESS_SSL_`. Modifying the process environment at this point is not safe as other actors might concurrently read out that same environment. Instead avoid changing the process environment altogether since flags can just as well be read from a map. Diffs ----- 3rdparty/libprocess/src/openssl.cpp c09cdc89509e4e4ca4c8a0f4fb0a57156a3a6091 src/master/allocator/mesos/hierarchical.cpp 3f51f4194c1ba7c1e4f08c3dd623281ca5754d39 src/master/master.hpp 48011eabda03986df3dfac124506645a398eaff4 Diff: https://reviews.apache.org/r/52154/diff/ Testing ------- Tested on various platforms in internal CI. Thanks, Benjamin Bannier